Gaëtan Gilbert (Oct 28 2022 at 16:57): Gaëtan Gilbert (Oct 28 2022 at 16:57):I saw this in the github settings, default disabled
should we enable it?
It adds a button to auto merge master into the branch or auto rebase the branch onto master (with a little dropdown to select which, same as eg closing as completed vs closing as wontfix)
Gaëtan Gilbert (Oct 28 2022 at 16:58):the default is auto merge and I don't see a way to change it so maybe misleading for our contributors
Ali Caglayan (Oct 28 2022 at 17:00):Doesn't it rebase on merge however?
Gaëtan Gilbert (Oct 28 2022 at 17:02):what do you mean?
Ramkumar Ramachandra (Oct 28 2022 at 17:09):PRs don't rebase-on-merge.
Théo Zimmermann (Oct 28 2022 at 17:22):There is a feature for rebase on merge but it is associated with the merge button, so it's a different thing.
Théo Zimmermann (Oct 28 2022 at 17:22):the default is auto merge and I don't see a way to change it so maybe misleading for our contributors
I think until we can change this, it may not be a good idea to activate this.
Last updated: Oct 13 2024 at 01:02 UTC