Stream: Nix toolbox devs & users

Topic: reviewers for coq-related PRs in Nixpkgs


view this post on Zulip cdepillabout (Sep 03 2022 at 00:42):

Hi, I recently sent a Coq-related PR to Nixpkgs: https://github.com/NixOS/nixpkgs/pull/188766

I haven't gotten a review yet, and I was wondering if there is anyone I can ping for a review. Is there anyone that generally reviews Coq-related PRs in Nixpkgs? It doesn't look like there are any Coq-related entries in the CODEOWNERS file, so I wasn't sure who is normally taking care of the Coq infrastructure!

view this post on Zulip Théo Zimmermann (Sep 03 2022 at 13:18):

Vincent Laporte is the most active committers, but I see that he has already posted a review now. Cyril Cohen and I also do maintenance / reviewing but without commit rights on nixpkgs.

view this post on Zulip cdepillabout (Sep 03 2022 at 13:41):

@Théo Zimmermann Thanks.

Is this the type of PR where you'd prefer me to wait for a review from you or Cyril, or something that might be okay to just go ahead and merge in?

view this post on Zulip Théo Zimmermann (Sep 03 2022 at 14:54):

I'd say generally feel free not to wait on a review on Cyril and I because we are unfortunately both too busy to be able to guarantee that we can review PRs in a reasonable time frame. That being said, when something looks important, I sometimes look at it even after it has been merged, and can still comment on it if I have changes to suggest.

view this post on Zulip cdepillabout (Sep 03 2022 at 17:54):

Okay, thanks, that makes sense.

view this post on Zulip cdepillabout (Sep 04 2022 at 17:32):

@Théo Zimmermann Oh, I'm not sure if you saw, but I nominated you to get the commit bit in Nixpkgs and it looks like you were invited: https://github.com/NixOS/nixpkgs/issues/50105#issuecomment-1236127378

view this post on Zulip John Wiegley (Sep 06 2022 at 02:51):

Théo Zimmermann said:

Vincent Laporte is the most active committers, but I see that he has already posted a review now. Cyril Cohen and I also do maintenance / reviewing but without commit rights on nixpkgs.

I also do reviewing from time to time, and have commit rights, so feel free to ping me if needed.


Last updated: Jan 29 2023 at 14:02 UTC