Enrico Tassi (Jan 04 2021 at 10:16): Enrico Tassi (Jan 04 2021 at 10:16):@Guillaume Melquiond I did struggle a bit in setting up the coq-gappa package (we need a patch on top of 1.4.5. on windows).
The problem is that if you backport from upstream a commit to configure.in as an opam patch then it is not really used unless the url stanza points to a git repo. If it points to a released archive, then {dev} is false, the patch applied but configure not re-generated. I did move the platform overlay package from one picking a commit (and applying a patch) to one picking a released version and applying another patch, and things stopped working.
What is wrong with running autoconf always? (I'm not an auto* expert)
Karl Palmskog (Jan 04 2021 at 10:18):hmm, I think autoconf is a quite big system package that does not come preinstalled for most people on Linux, Cygwin, etc. So forcing that dependency is in itself quite intrusive
Guillaume Melquiond (Jan 04 2021 at 10:25):Yes, that is the idea, autoconf is not meant to be forced upon every user. The motto is to generate configure once and ship it and be done with autoconf.
Guillaume Melquiond (Jan 04 2021 at 10:26):Also, I am not quite sure to understand. If your patch is taken from upstream, why not just point to the corresponding commit? Why try to backport it to a released version?
Guillaume Melquiond (Jan 04 2021 at 10:26):Anyway, if you tell me that the upstream version works fine, I can just release it as a bugfix version.
Enrico Tassi (Jan 04 2021 at 10:28):I'm testing it
Enrico Tassi (Jan 04 2021 at 10:29):here: https://github.com/coq/platform/actions/runs/460812058
Enrico Tassi (Jan 04 2021 at 10:33):I could point to a commit (I was) but I prefer a release tarball + a delta. Maybe it just looks like Debian, maybe I'm using git -f too much myself to believe others never do
Michael Soegtrop (Jan 04 2021 at 10:59):@Enrico Tassi : for Coq Platform autoconf should be available since a few packages need it. In my experience it is more reliably to call autoreconf.
Enrico Tassi (Jan 04 2021 at 11:05):It needs to be available also for coq-gappa.dev (maybe a depends: [ conf-autoconf {dev} ] line is missing there?).
Anyway, for the PR in question https://github.com/coq/platform/pull/56 for the v8.13 platform branch I just put in the patch the diff on ./configure itself, so it will work, eventually.
Michael Soegtrop (Jan 04 2021 at 11:53):@Enrico Tassi : yes, since (https://gitlab.inria.fr/gappa/coq) has a configure.in but no configure file, at least the dev version does require autoconf, so the dependency should be there. As far as I remember the release archives do contain the configure file, so that autoconf is not required for releases.
Last updated: Apr 18 2024 at 12:01 UTC