@Assia Mahboubi please see https://github.com/math-comp/apery/pull/5 for some boilerplate improvements to Apery. (This is an example of the kind of PR I could take care of autonomously, with your permission)
@Karl Palmskog Many thanks! And thanks as well for this message, which drew my attention to your kind PR.
Indeed, I should and will release and create the corresponding opam package asap.
Follow-up: In the end, after the last MC dev meeting, we decided to move this project to coq-community. Apery will in particular serve as a guinea ping for possibly moving the other projects currently under the mathcomp organisation.
@Assia Mahboubi here is the link to begin to move a project to coq-community: https://github.com/coq-community/manifesto/issues/new?assignees=&labels=move-project&template=1-move-a-project.md&title=Proposal+to+move+project+Apery+to+coq-community
Let me know if anything is unclear.
here's an example of a project that was moved: https://github.com/coq-community/manifesto/issues/136
We'd normally like all authors/copyright holders to approve of a move, but they don't have to approve directly on GitHub, e.g., it's fine to just send them an email and write in the GitHub issue when you hear back.
Thanks @Karl Palmskog ! I will create the issue and continue the discussion there (if needed).
@Assia Mahboubi I think things look good in https://github.com/coq-community/apery/pull/8 - so I'll merge in the next hour unless you have concerns. After that, I recommend deleting the old tag and making a new release from scratch on GitHub (which will recreate the tag)
Please proceed, many thanks!
OK, then I do the release as well while I'm at it...
By "the old tag" are you refering to the one from March 20? This one was for the submission of a companion paper. But it is not of the highest importance I would say.
ah OK, if you want to keep that tag, we could just do a release called 1.0.1
Perfect.
Please proceed with the release if you wish. Or I will do it later on.
I'll do it quickly once CI finishes. You can edit release text later if you want. My main goal is just to get the opam package into the archive. MathComp tends to be so stable a release can last for 1+ year.
@Kazuhiko Sakaguchi do you want to join coq-community so you can merge https://github.com/coq-community/apery/pull/4 yourself when it is ready?
@Karl Palmskog Yes, but that PR will not be merged very soon. The story behind the PR is that I use it as a benchmark in a draft paper about Algebra Tactics. So I think it will be merged when the final version of the paper is ready.
OK, sounds good, but I was indeed thinking about the long, long term here.
our general philosophy is that our community is small and manpower is scarce, so people interested in a project should be empowered to do basic tasks, and we will assume they synchronize with maintainers at appropriate intervals.
nevertheless, maintainers can choose to be more strict about repo privileges if they wish
Regarding this repo at least, I think that the general philosophy you describe is very (wise and) relevant.
I personally also like to keep PRs as repo branches, rather than in forks, since more in community spirit and sometimes easier to pass PRs between people
Indeed, fine with me.
Karl Palmskog said:
I personally also like to keep PRs as repo branches, rather than in forks, since more in community spirit and sometimes easier to pass PRs between people
Yeah, this is a good strategy as long as the number of open PRs is small.
also quick check @Théo Zimmermann if we could set up up GitLab repo mirroring for Apery
@Assia Mahboubi don't forget Kazuhiko's refactoring PR: https://github.com/coq-community/apery/pull/9
It looks good to me, and also does a nice small fix to CI
Last updated: Feb 08 2023 at 07:02 UTC