Stream: coq-community devs & users

Topic: Deprecations for Docker-Coq-Action

Karl Palmskog (Nov 14 2022 at 10:25):

@Erik Martin-Dorel I keep seeing messages like this in the log when using Docker-Coq-Action with Coq 8.14 and lower:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/checkout

Do you know what this is about? Should I open an issue somewhere?

Théo Zimmermann (Nov 14 2022 at 11:23):

@Karl Palmskog Do you have a link to the problematic runs?

Karl Palmskog (Nov 14 2022 at 13:38):

@Théo Zimmermann see "Annotations" here for example: https://github.com/uwplse/StructTact/actions/runs/3459901889

Théo Zimmermann (Nov 14 2022 at 13:40):

This example also includes warnings for Coq > 8.14, which is not surprising given that this does not look very specific to a Coq version, or even to Docker-Coq-Action.

Karl Palmskog (Nov 14 2022 at 13:42):

OK, so I guess it's independent of Coq version. But for some examples I looked at, it was restricted to some Coq versions

Théo Zimmermann (Nov 14 2022 at 13:43):

It looks like we need to update to actions/checkout@v3.

Théo Zimmermann (Nov 14 2022 at 13:46):

And indeed, we are also getting these warnings here https://github.com/coq/coq/actions/runs/3461634646 (no use of Docker-Coq-Action, but of actions/checkout@v2).

Karl Palmskog (Nov 14 2022 at 13:55):

wait, so this is a change we need to do in docker-action.yml for all projects that use Docker-Coq-Action?

Erik Martin-Dorel (Nov 14 2022 at 14:17):

Hi @Karl Palmskog !

Should I open an issue somewhere?

Both are fine :)

• you don't need to open an issue right now, I'll take a look this week on this deprecation warning.
• but in general feel free to open issues directly in the docker-coq-action repo, they are very welcome as well!

Thanks for the ping, Karl!

Erik Martin-Dorel (Nov 14 2022 at 14:18):

If we confirm that the culprit is the checkout@v2, then it is actually not a docker-coq-action issue, but a coq-community-templates one (?)

Karl Palmskog (Nov 14 2022 at 14:21):

@Erik Martin-Dorel OK, I'll wait for your comments, but I think we have to update documentation as well if it's checkout@v2? For example: https://github.com/erikmd/docker-coq-github-action-demo/blob/master/.github/workflows/build-coq-demo.yml

Erik Martin-Dorel (Nov 14 2022 at 14:22):

Ah indeed, good point !-)

Théo Zimmermann (Nov 15 2022 at 08:02):

Yes, we only need to fix the documentation and the templates. IMHO no need to wait for Erik's investigation. My example from the Coq repository clearly shows this has nothing to do with Docker-Coq-Action.

Last updated: Jun 06 2023 at 23:01 UTC