anyone else getting this? https://github.com/coq/coq/runs/5661145885?check_suite_focus=true
it's doing that on all recent PRs it seems
CC @Michael Soegtrop
the platform side CI should have a job doing what we do on the coq side
it should have it already
there is a dev job on coq master / platform master. I don't know what broke exactly
@Gaëtan Gilbert : I guess this is my bad preparing the Coq Platform delivery. Since a Coq Platform CI run takes 6 hours I sometimes take a few shortcuts in CI and fix things later.
I think Coq CI should not be using Coq Platform main, but the latest release scripts of Coq Platform. The dev pick used in Coq CI doesn't really change between Coq Platform releases - what changes are the new picks and script features.
So please replace main here (https://github.com/coq/coq/blob/68fbd9ddf90f9da5fdbde0b68f8e9580463925b3/.github/workflows/ci-windows.yml#L31) with a tag.
Well let me do a PR right away ...
Ehm sorry, need to do something else. @Gaëtan Gilbert : can you please do the change to the latest release tag - should be (https://github.com/coq/platform/archive/refs/tags/2022.01.0.zip) instead of (https://github.com/coq/platform/archive/main.zip)
The system cannot find the path specified. ERROR .\dev\ci\platform\coq-pf-04-installer.bat failed Error: Process completed with exit code 1.
So it downloads fine but then fails at a when building the installer?
I've restarted the windows job again just in case it was a one off
Nope looks broken
Looks like the build platform step is failing even though it succeeded on github
where did it succeed?
It didn't but it didn't throw a failure
I found the problem
There is something overriding the dev package that it expects
Since we didn't provide a dev package it doesn't know what to do with those options
I suspect if we remove
-override-dev-pkg="coq=%GITHUB_SERVER_URL%/%GITHUB_REPOSITORY%/archive/%GITHUB_SHA%.tar.gz" ^ -override-dev-pkg="coqide=%GITHUB_SERVER_URL%/%GITHUB_REPOSITORY%/archive/%GITHUB_SHA%.tar.gz" ^
it might do better
Shall I push a fix?
The reason I suspect is this:
Run .\dev\ci\platform\coq-pf-03-build.bat Install cygwin and download, compile and install OCaml and Coq for MinGW !!! Illegal parameter -override-dev-pkg
The build script from the CI
but now that I think about it it might break a lot of other things
As I understand it, that script expects the dev zip to be provided not some release. So when we gave it a release zip it didn't know what to do with the extra -override-dev-pkg options
Maybe its better just to wait for @Michael Soegtrop
If the platform is going to be disruptive in the meantime we can always allow_fail
The issue is just that this option was added after the last release: https://github.com/coq/platform/pull/223
So the suggestion of Michael to use a released version doesn't work until the next one.
That being said, we can certainly ping to a non-released commit.
And github is down again https://www.githubstatus.com/
Not a good time to try fixing a CI issue :face_palm:
Sorry, I didn't follow what the issue is. My points are:
Uhm wait ...
Sorry, @Théo Zimmermann is right, you have to use commit 88d69fcd97b313de1c6e39b9439234ad6e863f21. The 2022.01 tag doesn't have the dev package override features yet.
The PR from @Gaëtan Gilbert works now (at least regarding the Windows build).
Sorry for the fuzz - I keep forgetting that Coq CI uses this, so I think it is a good move to use specific version of Coq Platform in Coq CI.
Last updated: May 28 2023 at 13:30 UTC