Stream: Coq devs & plugin devs

Topic: Uninstallable CoqIDE 8.12.0-1 in OPAM

view this post on Zulip Karl Palmskog (Oct 28 2020 at 06:38):

Someone in the OCaml organization on GitHub added the following uninstallable version of CoqIDE into the opam repo: https://github.com/ocaml/opam-repository/commit/a037ee74ee61dc319e756b6212728e5c7017b78e https://github.com/ocaml/opam-repository/tree/master/packages/coqide/coqide.8.12.0-1

Does anybody know what this is about? This is likely to confuse the heck out of users...

view this post on Zulip Enrico Tassi (Oct 28 2020 at 07:11):

I guess it was a mistake. We should report the issue or directly amend with a pr. Mseri is usually very responsive.

view this post on Zulip Théo Zimmermann (Oct 28 2020 at 07:36):

See the corresponding PR: https://github.com/ocaml/opam-repository/pull/17445

view this post on Zulip Théo Zimmermann (Oct 28 2020 at 07:36):

Despite being done in a separate commit, this was in fact a PR introducing the required change from gnome to adwita (in parallel from the one of Michael doing this on every versions).

view this post on Zulip Théo Zimmermann (Oct 28 2020 at 07:37):

But the maintainer that did the split into a new version did not realize that this would cause the package to be uninstallable due to the version constraints.

view this post on Zulip Théo Zimmermann (Oct 28 2020 at 07:41):

What is quite surprising though is that the maintainer also did not realize that they had previously merged a different PR with the same fix :face_palm:

view this post on Zulip Michael Soegtrop (Oct 28 2020 at 09:42):

Also it changes the icon theme back from adwaita - this is simply wrong.

view this post on Zulip Théo Zimmermann (Oct 28 2020 at 10:04):

Despite what this commit seemingly did to the original package, the PR must be taken as a whole: it didn't change anything to the 8.12.0 version and thus your fix was still there.

view this post on Zulip Théo Zimmermann (Oct 28 2020 at 10:04):

Anyway, now I believe this is all fixed.

view this post on Zulip Michael Soegtrop (Oct 28 2020 at 16:30):

Yes, I reviewed the master branch and it looks good there. Still I think it made sense to emphasize once more that Adwaita is the right thing and gnome icon theme is the wrong thing to install and if this fails for whatever reason this failure must be fixed and not the dependency changed.

Last updated: Jun 08 2023 at 04:01 UTC