Is there a reason why we still have some standalone devs without a proper job in the CI? It's annoying for overlays, because they're hardcoded in the downstream script.
I am thinking for instance of verdi_raft, which embeds struct_tact, inf_seq_ext, cheerios and verdi.
Lack of manpower @Pierre-Marie Pédrot
ok, so no real reason
not sure what the point of splitting the verdi script would be tbh
there is a lot of improvements we could do w.r.t. overlays, i have a long list
when I have a bit of time I will write a patch then
just didn't found an intern or engineer to help with them
@Gaëtan Gilbert the dev tool scripts do not support internal deps
Indeed I think that overlays should work for devs as in the fast CI mode we discussed
and have much better dev scripts
what scripts?
./create-overlays
^ this
right I guess you still need to comment out the make line
also it's annoying from the github UI in case of failure because it's misleading
my understanding is that we did that when dep management was a hell in gitlab ci:
with all the pipeline depth and whatnot
now that gitlab provides a straightforward graph dep model it should be free
each job has about 5min of startup + end time so we don't want to split too much
yet another argument to reduce the size of vo files (and hence docker images)
I can live with this but I think it's quite a wart
I think first we should split the docker image into one image for base and one for edge
vo files aren't in the docker image btw
can't we split the scripts but run several of them in the gitlab ci yml file in a single target?
this would solve most of my problems
sure
with the current way it's written when there are missing deps they just get run too so it's easy
as de facto maintainer of verdi_raft and friends, please let me know if we can do anything on repo side to help devs out.
Last updated: Jun 09 2023 at 07:01 UTC