Stream: Coq devs & plugin devs

Topic: Backporting #15271


view this post on Zulip Jason Gross (Jun 23 2022 at 14:01):

Can https://github.com/coq/coq/pull/15271 be backported to v8.9--v8.14? It's a small change, and not having it continues to cause build issues on coq-performance-tests CI (which builds plots for old versions of Coq). I'm fine with it only being on the dev branch (happy to have the CI use the dev branch for old versions of Coq). (If it's okay to backport, I can even prepare the backporting PRs myself.)

view this post on Zulip Emilio Jesús Gallego Arias (Jun 23 2022 at 14:22):

I guess that'd be fine @Jason Gross

view this post on Zulip Théo Zimmermann (Jun 23 2022 at 15:28):

Probably you will have to prepare the backporting PRs and also merge them yourself because retired RMs might not want to do it. You will need to use the dev/merge-pr.sh script for this. Note that you may encounter CI issues on older branches since we don't maintain them, so we don't know if something non-reproducible broke.

view this post on Zulip Jason Gross (Jun 23 2022 at 16:16):

Created https://github.com/coq/coq/pull/16231, https://github.com/coq/coq/pull/16232, https://github.com/coq/coq/pull/16233, https://github.com/coq/coq/pull/16234, https://github.com/coq/coq/pull/16235, https://github.com/coq/coq/pull/16236, https://github.com/coq/coq/pull/16238. Do I need to get approvals, tag specific RMs, etc?

view this post on Zulip Jason Gross (Jun 23 2022 at 16:16):

(Is there a list of RMs somewhere?)

view this post on Zulip Théo Zimmermann (Jun 23 2022 at 16:16):

No, there's no process for backporting to older branches.

view this post on Zulip Karl Palmskog (Jun 23 2022 at 17:17):

@Jason Gross you may want to consider submitting patches to the official opam Coq packages as an alternative

view this post on Zulip Karl Palmskog (Jun 23 2022 at 17:18):

then there is a "process" of sorts, i.e., it might be merged by OCaml opam repo maintainers and may reach places like the Coq Platform

view this post on Zulip Jason Gross (Jun 23 2022 at 20:22):

Is there a way to fix
ERROR: Job failed: failed to pull image "registry.gitlab.com/coq/coq:bionic_coq-V2020-11-26-V93" with specified policies [always]: Error response from daemon: manifest for registry.gitlab.com/coq/coq:bionic_coq-V2020-11-26-V93 not found: manifest unknown: manifest unknown (manager.go:203:0s)
?

view this post on Zulip Jason Gross (Jun 23 2022 at 20:22):

(https://github.com/coq/coq/pull/16232)

view this post on Zulip Gaëtan Gilbert (Jun 23 2022 at 20:26):

I pushed a commit that should fix it

view this post on Zulip Jason Gross (Jun 23 2022 at 20:26):

Thanks! Is there a similar fix for https://github.com/coq/coq/pull/16231? (just put v8.14 in the same place?)

view this post on Zulip Gaëtan Gilbert (Jun 23 2022 at 20:27):

yes

view this post on Zulip Gaëtan Gilbert (Jun 23 2022 at 20:28):

well only in the yml for 8.14 since CACHEKEY handling was simplified a bit


Last updated: Jun 08 2023 at 04:01 UTC