Stream: Coq devs & plugin devs

Topic: windows github action


view this post on Zulip Gaëtan Gilbert (Apr 07 2021 at 09:23):

getting some assembler errors
https://github.com/coq/coq/pull/14079/checks?check_run_id=2278156510 in coq itself
https://github.com/coq/coq/pull/14079/checks?check_run_id=2285988551 in dune

view this post on Zulip Michael Soegtrop (Apr 07 2021 at 09:25):

@Gaëtan Gilbert : yes I have also seen this. It was introduced with a Cygwin update and is not reproducible - happens every 1000s file compiled or so. But it should be fixed by falling back to the old version - maybe that old version phased out now.

view this post on Zulip Michael Soegtrop (Apr 07 2021 at 09:30):

The log looks unfamiliar - I guess you went away from using Coq Platform again for CI. If so, you need the equivalent of the last patch in (https://github.com/coq/platform/blob/2021.02/shell_scripts/init_cygwin_fixes.sh)

view this post on Zulip Michael Soegtrop (Apr 07 2021 at 09:37):

I discussed this with the cygwin guys a while back, but they said that this are changes which came upstream from binutils and without reproduction it will be hard to argue with the binutils team. I guess at some point someone has to diff the sources and look for things which might have been messing things up.

view this post on Zulip Michael Soegtrop (Apr 07 2021 at 09:39):

Not sure if this is a cygwin only problem or Linuxes are just behind with their binutils version or it is something OCaml specific and rarely seen. I guess Coq is one of the larger OCaml projects with many CI builds.

view this post on Zulip Michael Soegtrop (Apr 07 2021 at 09:40):

But I must admit I currently have no bandwidth to look into this issue beyond the fallback "fix".

view this post on Zulip Michael Soegtrop (Apr 07 2021 at 09:40):

It is likely to fall on us some time, though.

view this post on Zulip Théo Zimmermann (Apr 07 2021 at 11:10):

The platform tests are still there but still on GitLab.

view this post on Zulip Michael Soegtrop (Apr 07 2021 at 14:25):

OK. If you have other Cygwin based Windows CI tests, they need the same patches as in the Coq Platform file I linked.

view this post on Zulip Michael Soegtrop (Apr 07 2021 at 14:26):

Does the other test update Cygwin on each CI run or do you user docker images?

view this post on Zulip Théo Zimmermann (Apr 07 2021 at 15:22):

I think they pull cygwin on each run.

view this post on Zulip Michael Soegtrop (Apr 07 2021 at 15:27):

Then I wonder why it din't show up before. I detected the issue in Platform CI end of January.

view this post on Zulip Théo Zimmermann (Apr 07 2021 at 15:28):

My guess (but I can't check right now): you fixed it already.

view this post on Zulip Théo Zimmermann (Apr 07 2021 at 15:28):

It just didn't get fix on the GitHub Action side.

view this post on Zulip Michael Soegtrop (Apr 07 2021 at 15:30):

It just didn't get fix on the GitHub Action side.

I mean why didn't it show up in the GitHub actions before?

view this post on Zulip Théo Zimmermann (Apr 07 2021 at 20:05):

I'm not sure. If it is infrequent, maybe it did and we just didn't notice it.


Last updated: Oct 21 2021 at 20:02 UTC