Stream: Coq devs & plugin devs

Topic: windows failing?


view this post on Zulip Gaëtan Gilbert (Mar 23 2022 at 13:53):

anyone else getting this? https://github.com/coq/coq/runs/5661145885?check_suite_focus=true

view this post on Zulip Pierre-Marie Pédrot (Mar 23 2022 at 13:53):

it's doing that on all recent PRs it seems

view this post on Zulip Enrico Tassi (Mar 23 2022 at 13:54):

CC @Michael Soegtrop

view this post on Zulip Gaëtan Gilbert (Mar 23 2022 at 13:54):

the platform side CI should have a job doing what we do on the coq side

view this post on Zulip Enrico Tassi (Mar 23 2022 at 14:03):

it should have it already

view this post on Zulip Enrico Tassi (Mar 23 2022 at 14:04):

there is a dev job on coq master / platform master. I don't know what broke exactly

view this post on Zulip Michael Soegtrop (Mar 23 2022 at 14:18):

@Gaëtan Gilbert : I guess this is my bad preparing the Coq Platform delivery. Since a Coq Platform CI run takes 6 hours I sometimes take a few shortcuts in CI and fix things later.

I think Coq CI should not be using Coq Platform main, but the latest release scripts of Coq Platform. The dev pick used in Coq CI doesn't really change between Coq Platform releases - what changes are the new picks and script features.

view this post on Zulip Michael Soegtrop (Mar 23 2022 at 14:20):

So please replace main here (https://github.com/coq/coq/blob/68fbd9ddf90f9da5fdbde0b68f8e9580463925b3/.github/workflows/ci-windows.yml#L31) with a tag.

view this post on Zulip Michael Soegtrop (Mar 23 2022 at 14:21):

Well let me do a PR right away ...

view this post on Zulip Michael Soegtrop (Mar 23 2022 at 14:23):

Ehm sorry, need to do something else. @Gaëtan Gilbert : can you please do the change to the latest release tag - should be (https://github.com/coq/platform/archive/refs/tags/2022.01.0.zip) instead of (https://github.com/coq/platform/archive/main.zip)

view this post on Zulip Gaëtan Gilbert (Mar 23 2022 at 14:27):

https://github.com/coq/coq/pull/15851

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:30):

The system cannot find the path specified.
ERROR .\dev\ci\platform\coq-pf-04-installer.bat failed
Error: Process completed with exit code 1.

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:36):

So it downloads fine but then fails at a when building the installer?

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:37):

I've restarted the windows job again just in case it was a one off

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:38):

Nope looks broken

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:41):

Looks like the build platform step is failing even though it succeeded on github

view this post on Zulip Gaëtan Gilbert (Mar 23 2022 at 14:43):

where did it succeed?

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:44):

It didn't but it didn't throw a failure

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:44):

I found the problem

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:44):

https://github.com/coq/coq/blob/master/dev/ci/platform/coq-pf-03-build.bat

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:44):

There is something overriding the dev package that it expects

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:44):

Since we didn't provide a dev package it doesn't know what to do with those options

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:45):

I suspect if we remove

  -override-dev-pkg="coq=%GITHUB_SERVER_URL%/%GITHUB_REPOSITORY%/archive/%GITHUB_SHA%.tar.gz" ^
  -override-dev-pkg="coqide=%GITHUB_SERVER_URL%/%GITHUB_REPOSITORY%/archive/%GITHUB_SHA%.tar.gz" ^

it might do better

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:45):

Shall I push a fix?

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:46):

The reason I suspect is this:

Run .\dev\ci\platform\coq-pf-03-build.bat
Install cygwin and download, compile and install OCaml and Coq for MinGW
!!! Illegal parameter -override-dev-pkg

view this post on Zulip Gaëtan Gilbert (Mar 23 2022 at 14:49):

what fix?

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:50):

The build script from the CI

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:50):

but now that I think about it it might break a lot of other things

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:50):

https://github.com/coq/coq/blob/master/dev/ci/platform/coq-pf-03-build.bat

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:51):

As I understand it, that script expects the dev zip to be provided not some release. So when we gave it a release zip it didn't know what to do with the extra -override-dev-pkg options

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:53):

Maybe its better just to wait for @Michael Soegtrop

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:54):

If the platform is going to be disruptive in the meantime we can always allow_fail

view this post on Zulip Théo Zimmermann (Mar 23 2022 at 14:54):

The issue is just that this option was added after the last release: https://github.com/coq/platform/pull/223

view this post on Zulip Théo Zimmermann (Mar 23 2022 at 14:54):

So the suggestion of Michael to use a released version doesn't work until the next one.

view this post on Zulip Théo Zimmermann (Mar 23 2022 at 14:55):

That being said, we can certainly ping to a non-released commit.

view this post on Zulip Ali Caglayan (Mar 23 2022 at 14:59):

And github is down again https://www.githubstatus.com/

view this post on Zulip Théo Zimmermann (Mar 23 2022 at 15:01):

Not a good time to try fixing a CI issue :face_palm:

view this post on Zulip Michael Soegtrop (Mar 23 2022 at 15:57):

Sorry, I didn't follow what the issue is. My points are:

view this post on Zulip Michael Soegtrop (Mar 23 2022 at 15:58):

Uhm wait ...

view this post on Zulip Michael Soegtrop (Mar 23 2022 at 16:00):

Sorry, @Théo Zimmermann is right, you have to use commit 88d69fcd97b313de1c6e39b9439234ad6e863f21. The 2022.01 tag doesn't have the dev package override features yet.

view this post on Zulip Michael Soegtrop (Mar 23 2022 at 19:06):

The PR from @Gaëtan Gilbert works now (at least regarding the Windows build).
Sorry for the fuzz - I keep forgetting that Coq CI uses this, so I think it is a good move to use specific version of Coq Platform in Coq CI.


Last updated: Feb 05 2023 at 21:03 UTC