if you see a compcert or compcert-embedded-in-vst error like
File "./cfrontend/Ctypes.v", line 1905, characters 10-24: Error: Cannot infer an instance of type "Type" for the variable F
it is because they are waiting for an overlay merge
Why can't we apply overlays in our CI and stop applying them when they are merged?
I never understood why it only applied to the PR being merged.
Do you have a way of auto-detecting whether the overlay was merged?
Or would that require additional PRs (possibly opened automatically) to remove the overlays once they are not needed? (If that's the latter, then that would be close to a proposal I made years ago but which was blocked.)
gh CLI can detect if a PR is merged or not I believe. https://cli.github.com/manual/gh_pr_status
And when we detect the overlay has been merged we can emit a warning or do occasional batch clean ups.
We do this check when we are about to apply the overlay.
I'm sure there is a way to tell coqbot about it too.
Then coqbot can open a PR automatically cleaning up the overlays.
What coqbot could do would be to do a routine check every once in a while.
Every week would be sufficient IMO.
Ali Caglayan said:
ghCLI can detect if a PR is merged or not I believe. https://cli.github.com/manual/gh_pr_status
This obviously doesn't work for Gitlab however.
I don't think this is a good idea, because overlays can become very quickly obsolete.
@Pierre-Marie Pédrot What do you mean?
What do you fear @Pierre-Marie Pédrot?
Especially when there are competing PRs with overlays on the same dev, this means essentially adding a one week-delay for any progress
How is that any different to the current situation?
Hum? What are you talking about?
An overlay only makes sense for a given PR.
Once you start applying overlays for several branches you have to consider the possibility of conflict.
and the job will fail right?
So like it does today then
Yes, for everybody.
If an overlay has not been merged it will fail for everybody, today.
Today the lock is not on our side, which is the problem.
But making the lock time-based with a week delay is probably worse than a few hours, or days at best, of missing downstream dev overlays.
We are not making anything time based?
Last updated: Feb 02 2023 at 13:03 UTC