Stream: Coq devs & plugin devs

Topic: "Always suggest updating pull request branches" setting


view this post on Zulip Gaëtan Gilbert (Oct 28 2022 at 16:57):

I saw this in the github settings, default disabled
should we enable it?
It adds a button to auto merge master into the branch or auto rebase the branch onto master (with a little dropdown to select which, same as eg closing as completed vs closing as wontfix)

view this post on Zulip Gaëtan Gilbert (Oct 28 2022 at 16:58):

the default is auto merge and I don't see a way to change it so maybe misleading for our contributors

view this post on Zulip Ali Caglayan (Oct 28 2022 at 17:00):

Doesn't it rebase on merge however?

view this post on Zulip Gaëtan Gilbert (Oct 28 2022 at 17:02):

what do you mean?

view this post on Zulip Ramkumar Ramachandra (Oct 28 2022 at 17:09):

PRs don't rebase-on-merge.

view this post on Zulip Théo Zimmermann (Oct 28 2022 at 17:22):

There is a feature for rebase on merge but it is associated with the merge button, so it's a different thing.

view this post on Zulip Théo Zimmermann (Oct 28 2022 at 17:22):

the default is auto merge and I don't see a way to change it so maybe misleading for our contributors

I think until we can change this, it may not be a good idea to activate this.


Last updated: Feb 02 2023 at 15:04 UTC